Re: [Fwd: modified documents issue in abiword trunk]

HI Jean,

Thanks very much! I'll see if I can fix it today.

Cheers

Martin

On Tue, Oct 26, 2010 at 12:01 AM, Jean Brefort
<jean.brefort@normalesup.org> wrote:
> Should have cced the list, sorry
>
>
> ---------- Forwarded message ----------
> From: Jean Brefort <jean.brefort@normalesup.org>
> To: Martin Sevior <msevior@physics.unimelb.edu.au>
> Date: Mon, 25 Oct 2010 15:00:24 +0200
> Subject: modified documents issue in abiword trunk
> Hi Martin,
>
> Since some times, saving a document from abiword trunk does not anymore
> remove the dirty property of the document. I could track the issue to
> revision 27751 (lognpt branch) were you modified the
> PD_Document::_setClean() method:
>
> @@ -1177,8 +1177,6 @@
>
>  void PD_Document::_setClean(void)
>  {
> -       m_pPieceTable->setClean();
> -       m_pPieceTable->getFragments().cleanFrags();
>        _setForceDirty(false);
>  }
>
> Since isDirty() checks if the pt is clean, it always return true if the
> document has been modified, even if the file has been saved. Should
> isDirty() be modified to not check the piece table dirtiness anymore?
>
> Cheers,
> Jean
>
>
>
Received on Tue Oct 26 00:27:36 2010