re: urmaslt - r29811 - abiword/trunk/src/wp/impexp/xp

I'm not saying this is not needed but it is a potentially large change.

Can you give us an example where this patch fixes an import error?

Also how extensively have you tested this? There is a whole range of
RTF out there and one has to be very careful about what is accepted
and processed.

In other words I'm worried that the number of docs that this change
improves maybe outweighed by the number where this makes things worse.

So to reiterate, I'm not saying this is not needed, but I am asking
about how many different documents you tested this on.

Cheers,

Martin

Author: urmaslt
Date: 2011-06-11 12:56:40 +0200 (Sat, 11 Jun 2011)
New Revision: 29811

Modified:
   abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp
Log:
Fixed an issue with improper group closing for some \* keywords.

Modified: abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp
===================================================================
--- abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp 2011-06-09
04:53:53 UTC (rev 29810)
+++ abiword/trunk/src/wp/impexp/xp/ie_imp_RTF.cpp 2011-06-11
10:56:40 UTC (rev 29811)
@@ -8254,6 +8254,8 @@
                        nesting--;
                }
        }
+ // Reclaim group }
+ if (ch=='}') SkipBackChar(ch);
        xxx_UT_DEBUGMSG(("Return from List Table \n"));
        return true;
 }
@@ -8765,6 +8767,7 @@
                {
                        if (!ReadCharFromFile(&ch))
                                return false;
+
                        if(!ReadKeyword(keyword, &parameter,
&paramUsed, MAX_KEYWORD_LEN))
                        {
                                return false;
@@ -8782,6 +8785,7 @@
                        nesting--;
                }
        }
+ if (ch=='}') SkipBackChar(ch);
        return true;
 }
Received on Sat Jun 11 14:05:52 2011