Re: fidencio - r29870 - abiword/trunk/src/wp/ap/cocoa

On Fri, Jun 24, 2011 at 5:51 PM, J.M. Maurer <uwog@uwog.net> wrote:
>
> On Fri, 2011-06-24 at 09:43 -0300, Fabiano Fidêncio wrote:
>> On Fri, Jun 24, 2011 at 9:22 AM, J.M. Maurer <uwog@uwog.net> wrote:
>> > Would there be any way to generate an installable package when we do
>> > 2.9.1, so people can play with it?
>>
>> When are you thinking to release 2.9.1?
>
> Well, I was hoping to get it mostly done this weekend. When the actual
> release takes place is not set in store, but it could follow soon after.
>
>> I can't open/save ODT files, yet.
>> Where's this code to another platforms?
>> I'll add it ASAP and share a binary to test :-)
>
> It's a plugin (under ./plugins/opendocument/) which all platforms are
> required to build by default[1].
>
> Note that during the development of 2.9 we added some new dependencies
> to this plugin (such as redland), so I hope it still compiles. As far as
> I'm aware it compiled fine for 2.8.x.

Naaaah. I change my MacPorts to GentooPrefix and OpenDocument built,
without check for redland, without problems. It's not a problem, so.
:-)

>
> Cheers!
>  Marc
>
> [1] It is actually the only plugin that is required, since we find
> supporting the OpenDocument to be very important.
>
>
>
>
>> >
>> > We'll mark it as UBER-SUPER-PRE-ALPHA-BETA ofcourse :)
>> >
>> > Rock on,
>> >  Marc
>> >
>> > On Fri, 2011-06-24 at 02:48 -0300, Fabiano Fidêncio wrote:
>> >> Good news :-)
>> >>
>> >> Commit #29870 is fixing the most important crash that was found in AbiMac.
>> >>
>> >> Now, we can open a document, edit and save without crashes (okay,
>> >> maybe with a little crashes, I need to test it better).
>> >> There are a lot of minor issues to be fixed and it will be done ASAP.
>> >>
>> >> If there's another mac users in our list, please, enjoy it and report
>> >> found bugs. :-)
>> >> It isn't an alpha version, yet. But I like to think on it as a "pre"-alpha.
>> >>
>> >>
>> >> On Fri, Jun 24, 2011 at 2:36 AM,  <cvs@abisource.com> wrote:
>> >> >
>> >> > Author: fidencio
>> >> > Date: 2011-06-24 07:36:53 +0200 (Fri, 24 Jun 2011)
>> >> > New Revision: 29870
>> >> >
>> >> > Modified:
>> >> >   abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp
>> >> > Log:
>> >> > [mac] Fixing crash to open document
>> >> >
>> >> >    Please, *don't* modify the collection being enumerated.
>> >> >    In this case, just copy the array :-)
>> >> >
>> >> >
>> >> > Modified: abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp
>> >> > ===================================================================
>> >> > --- abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp 2011-06-24 05:22:29 UTC (rev 29869)
>> >> > +++ abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp 2011-06-24 05:36:53 UTC (rev 29870)
>> >> > @@ -420,20 +420,15 @@
>> >> >        XAP_Frame*      pFrame = getFrame();
>> >> >        NSView*         docArea = [_getController() getMainView];
>> >> >        NSArray*        docAreaSubviews;
>> >> > -
>> >> > -       docAreaSubviews = [docArea subviews];
>> >> > -       if ([docAreaSubviews count] != 0) {
>> >> > -               NSEnumerator *enumerator = [docAreaSubviews objectEnumerator];
>> >> > -               NSView* aSubview;
>> >> > -
>> >> > -               while ((aSubview = [enumerator nextObject])) {
>> >> > -                       [aSubview removeFromSuperviewWithoutNeedingDisplay];
>> >> > -               }
>> >> > -
>> >> > -               m_hScrollbar = NULL;
>> >> > -               m_vScrollbar = NULL;
>> >> > -               m_docAreaGRView = NULL;
>> >> > -       }
>> >> > +
>> >> > +    docAreaSubviews = [docArea subviews];
>> >> > +    if ([docAreaSubviews count] > 0) {
>> >> > +        for (NSView *aSubview in [docAreaSubviews copy])
>> >> > +            [aSubview removeFromSuperviewWithoutNeedingDisplay];
>> >> > +        m_hScrollbar = NULL;
>> >> > +        m_vScrollbar = NULL;
>> >> > +        m_docAreaGRView = NULL;
>> >> > +    }
>> >> >        NSRect frame = [docArea bounds];
>> >> >        NSRect controlFrame;
>> >> >
>> >> >
>> >> > -----------------------------------------------
>> >> > To unsubscribe from this list, send a message to
>> >> > abisource-cvs-commit-request@abisource.com with the word
>> >> > unsubscribe in the message body.
>> >> >
>> >>
>> >> Best Regards,
>> >
>> >
>> >
>>
>>
>>
>
>
>

-- 
Fabiano Fidêncio