Re: fidencio - r29870 - abiword/trunk/src/wp/ap/cocoa

Good news :-)

Commit #29870 is fixing the most important crash that was found in AbiMac.

Now, we can open a document, edit and save without crashes (okay,
maybe with a little crashes, I need to test it better).
There are a lot of minor issues to be fixed and it will be done ASAP.

If there's another mac users in our list, please, enjoy it and report
found bugs. :-)
It isn't an alpha version, yet. But I like to think on it as a "pre"-alpha.

On Fri, Jun 24, 2011 at 2:36 AM, <cvs@abisource.com> wrote:
>
> Author: fidencio
> Date: 2011-06-24 07:36:53 +0200 (Fri, 24 Jun 2011)
> New Revision: 29870
>
> Modified:
>   abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp
> Log:
> [mac] Fixing crash to open document
>
>    Please, *don't* modify the collection being enumerated.
>    In this case, just copy the array :-)
>
>
> Modified: abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp
> ===================================================================
> --- abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp 2011-06-24 05:22:29 UTC (rev 29869)
> +++ abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp 2011-06-24 05:36:53 UTC (rev 29870)
> @@ -420,20 +420,15 @@
>        XAP_Frame*      pFrame = getFrame();
>        NSView*         docArea = [_getController() getMainView];
>        NSArray*        docAreaSubviews;
> -
> -       docAreaSubviews = [docArea subviews];
> -       if ([docAreaSubviews count] != 0) {
> -               NSEnumerator *enumerator = [docAreaSubviews objectEnumerator];
> -               NSView* aSubview;
> -
> -               while ((aSubview = [enumerator nextObject])) {
> -                       [aSubview removeFromSuperviewWithoutNeedingDisplay];
> -               }
> -
> -               m_hScrollbar = NULL;
> -               m_vScrollbar = NULL;
> -               m_docAreaGRView = NULL;
> -       }
> +
> +    docAreaSubviews = [docArea subviews];
> +    if ([docAreaSubviews count] > 0) {
> +        for (NSView *aSubview in [docAreaSubviews copy])
> +            [aSubview removeFromSuperviewWithoutNeedingDisplay];
> +        m_hScrollbar = NULL;
> +        m_vScrollbar = NULL;
> +        m_docAreaGRView = NULL;
> +    }
>        NSRect frame = [docArea bounds];
>        NSRect controlFrame;
>
>
> -----------------------------------------------
> To unsubscribe from this list, send a message to
> abisource-cvs-commit-request@abisource.com with the word
> unsubscribe in the message body.
>

Best Regards,

-- 
Fabiano Fidêncio