Re: urmaslt - r29620 - abiword/trunk/plugins/mswrite/xp

Hi Ingo,
Thanks for your contribution. I didn't go through the patch and the
diff. As I feel, Urmas, as the committer, can review and commit a part
or full of your patch. Usually we can't expect the entire patch to be
committed as it is. Since Urmas had to review the patch before
committing, he might have omitted a few code segments in doubt.

However it was great to see Urmas taking care of the BugZilla and
applying some of the old patches that haven't been applied to trunk
for a while. Since Urmas is a new committer, we shall encourage him
even if he has mistakenly omitted a few line segments among the
patches. The developers are keeping an eye and will always assist each
other.

Really glad to see many issues being fixed recently.
Keep contributing.

Thank you.
Regards,
Pradeeban.

On Mon, Mar 7, 2011 at 12:08 AM, Ingo Brückl <ib@wupperonline.de> wrote:
> Urmas wrote on Sun, 6 Mar 2011 22:49:23 +0600:
>
>> That is the patch [...]
>
> This is correct. This was my patch.
>
>> [...] that I applied. [...] and obviously could not be patched.
>
> I doubt this.
>
> I just applied the patch to a pre-r29620 version (svn merge -rHEAD:29617 .)
> without any problem:
>
>  $ patch -p1 < ~/abiword.patch
>  patching file plugins/mswrite/xp/ie_imp_MSWrite.cpp
>  patching file plugins/mswrite/xp/ie_imp_MSWrite.h
>  patching file plugins/mswrite/xp/ie_impexp_MSWrite.cpp
>  patching file plugins/mswrite/xp/ie_impexp_MSWrite.h
>
>> Which parts *exactly* are missing?
>
> Find attached the difference between the pre-r29620 patched version and
> r29620 and you'll see.
>
> Ingo
>

-- 
Kathiravelu Pradeeban.
Software Engineer.
WSO2 Inc.
Blog: [Llovizna] http://kkpradeeban.blogspot.com/