Re: Re: Bug fix

yes. so in my patch

I change the function to T_legalizeFileName(std::string &filename);

see my patch in bug 13313



--------------
vincent.abiword
>
>On 01/04/12 11:32 PM, vincent vincent wrote:
>>
>> Hi, Diana
>>
>> I am Vincent. I think the bug fixing about UT_legalizeFileName is not
>> a better solution,
>>
>> From the code level:
>> -ABI_EXPORT bool UT_legalizeFileName(std::string &filename);
>> +ABI_EXPORT bool UT_legalizeFileName(UT_UTF8String &filename);
>>
>> + UT_legalizeFileName((UT_UTF8String)title); => I think this will
>> create a temp variable, so that tile will not be change using &
>
>It just won't work. Given that it is passed by reference, there is no
>conmversion and the build will fail.
>
>The caller should be change to pass a std::string, if that's really the
>problem.
>
>Off course I didn't see a proper bug report about that, so I'm just
>guessing.
>
>
>Hub
Received on Mon Apr 2 17:32:04 2012