Vincent_ what is the expected behavior for Frame setting dialog

Hi Martin,
I am Vincent.
Recently, I try to fix the following two bugs, but I have something to confirm with you.

1. http://bugzilla.abisource.com/show_bug.cgi?id=13308
Frame format setting dialog can't remember user's thickness setting.

in fact, user can set Frame's top, left, right, bottom thickness. so which thickness should we display when user open Frame setting dialog?
        a. first time open Frame setting dialog(no setting Frame thickness before) ==> we can display default thickness.
        b. not first time =====>
            if users set top, left, right, bottom thickness the same =======> we can display the same value
            if users set top, left, right, bottom thickness seperately to not the same =====> what should we display?

right now, the behavior of setting top, left, right, bottom thicknes in Frame setting dialog is confusing. I think I need to confirm with you before fixing it. Can you have a try about it. thanks

 
2. http://bugzilla.abisource.com/show_bug.cgi?id=7976
   top left conner of textbox - lines do not start from same point

I have invesigate a long about this bug. But I don't why this happens, since the left-top Coordinate is the same while drawline in

/*!
 * Draw the frame boundaries
 */
void fp_FrameContainer::drawBoundaries(dg_DrawArgs * pDA)
{
        ..............
        _drawLine(m_lineTop,iXlow,iYlow,iXhigh,iYlow,pDA->pG); // top
        _drawLine(m_lineRight,iXhigh,iYlow,iXhigh,iYhigh,pDA->pG); // right
        _drawLine(m_lineBottom,iXlow,iYhigh,iXhigh,iYhigh,pDA->pG); // bottom
        _drawLine(m_lineLeft,iXlow,iYlow,iXlow,iYhigh,pDA->pG); // left
}



I am looking forward to hearing from you. thanks

Vincent
Received on Tue Apr 3 18:22:31 2012