Re: slaroche - r30681 - abiword/trunk/src/text/fmt/xp

On 01/03/12 07:01 PM, cvs@abisource.com wrote:
> ===================================================================
> --- abiword/trunk/src/text/fmt/xp/fl_SectionLayout.h 2012-02-29 22:22:44 UTC (rev 30680)
> +++ abiword/trunk/src/text/fmt/xp/fl_SectionLayout.h 2012-03-02 03:01:01 UTC (rev 30681)
> @@ -297,6 +297,7 @@
> void prependOwnedHeaderPage(fp_Page * p_Page);
> void prependOwnedFooterPage(fp_Page * p_Page);
> void deleteOwnedPage(fp_Page*, bool bReallyDeleteIT=true);
> + fp_Page * getFirstOwnedPage(void) { return m_pFirstOwnedPage;}

Shouldn't this method be const?

> Modified: abiword/trunk/src/text/fmt/xp/fl_TOCLayout.h
> ===================================================================
> --- abiword/trunk/src/text/fmt/xp/fl_TOCLayout.h 2012-02-29 22:22:44 UTC (rev 30680)
> +++ abiword/trunk/src/text/fmt/xp/fl_TOCLayout.h 2012-03-02 03:01:01 UTC (rev 30681)
> @@ -126,10 +126,12 @@
> fl_BlockLayout * findMatchingBlock(fl_BlockLayout * pBlock);
> UT_sint32 isInVector(fl_BlockLayout * pBlock, UT_GenericVector<TOCEntry *>* pVecBlocks);
> UT_uint32 getTOCPID(void) const { return m_iTOCPID;}
> + bool isTOCEmpty() {return (m_vecEntries.getItemCount() == 0);}

And this one.

> Modified: abiword/trunk/src/text/fmt/xp/fp_Page.h
> ===================================================================
> --- abiword/trunk/src/text/fmt/xp/fp_Page.h 2012-02-29 22:22:44 UTC (rev 30680)
> +++ abiword/trunk/src/text/fmt/xp/fp_Page.h 2012-03-02 03:01:01 UTC (rev 30681)
> @@ -157,6 +157,7 @@
> bool overlapsWrappedFrame(UT_Rect & rec);
> void setPageNumberInFrames(void);
> UT_sint32 getPageNumber(void); // TODO make const
> + UT_sint32 getFieldPageNumber(void);

And this one.

Cheers,

Hub
Received on Fri Mar 2 05:56:30 2012