Re: Bug fix

From: Diana Maria Prajescu <diana.prajescu_at_gmail.com>
Date: Sun Mar 18 2012 - 18:00:50 CET

Hello,

I have attached all the patches needed so that there wouldn't be any
build errors.

- msvc2008Patch.patch is for the msvc2008 folder
- srcPatch.patch is for the src folder
- pluginsPatch.patch is for the plugins folder

Regards,
Diana Prajescu

On Sun, Mar 18, 2012 at 4:54 PM, Diana Maria Prajescu
<diana.prajescu@gmail.com> wrote:
> Great. Thanks very much. That errors are because some linkages are
> missing from the solution not because of strptime.
>
> I've managed to determine the source of the errors and find a way to
> get it running by commenting out 2 lines of code. I am still trying to
> fix them without commenting out those lines. I will put here a patch
> for that too, so you could take a look over if you may want.
>
> --
> Diana Prajescu
>
> 2012/3/18 Lubos Pintes <pintes@gmail.com>:
>> Ok now it worked for me. I did the following:
>> 1. svn revert -R . for main AbiWord checkout folder and then for msvc2008
>> folder.
>> 2. Copied strptime.patch to the main AbiWord folder and
>> LibAbiWord.vcproj.patch to the msvc2008 folder.
>> 3. In main folder: patch -p0 <strptime.patch
>> 4. In msvc2008 folder: patch -p0 <LibAbiWord.vcproj.patch
>> 5. Patch was applied successfully, build was ok but I received this linker
>> error:
>> 1>ap_EditMethods.obj : error LNK2019: unresolved external symbol "bool
>> __cdecl UT_legalizeFileName(class std::basic_string<char,struct
>> std::char_traits<char>,class std::allocator<char> > &)"
>> (?UT_legalizeFileName@@YA_NAAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
>> referenced in function "bool __cdecl s_AskForPathname(class XAP_Frame
>> *,bool,int,char const *,char * *,int *)"
>> (?s_AskForPathname@@YA_NPAVXAP_Frame@@_NHPBDPAPADPAH@Z)
>>
>> Dňa 18. 3. 2012 14:41, Diana Maria Prajescu  wrote / napísal(a):
>>
>>> Hey,
>>>
>>> I have reviewed it and it seems that there should be 2 patches:
>>> 1) strptime.patch: updates the sources to solve the strptime problem
>>> for repo: http://svn.abisource.com/abiword/trunk/. I have created it
>>> on the src folder.
>>>
>>> There is a small problem with it. When I apply the patch to a clean
>>> copy of the SVN, the ap_Dialog_Latex.cpp and ut_std_string.cpp aren't
>>> patched. I don't understand why.. The error I got when I try to do
>>> this is "Rejected patch hunk".
>>>
>>> 2) LibAbiWord.vcproj.patch: it's the patch which adds the sources from
>>> strptime.patch to the solution. I have created it on the msvc2008
>>> folder for the repo: http://svn.abisource.com/abiword-msvc2008/trunk/
>>>
>>> These 2 patches are attached. I would be thankful if anyone can test
>>> them and let me know the results.
>>>
>>> --
>>> Many thanks,
>>> Diana Prajescu

Received on Sun Mar 18 18:01:01 2012

This archive was generated by hypermail 2.1.8 : Sun Mar 18 2012 - 18:01:01 CET