Re: Bug fix

Great. Thanks very much. That errors are because some linkages are
missing from the solution not because of strptime.

I've managed to determine the source of the errors and find a way to
get it running by commenting out 2 lines of code. I am still trying to
fix them without commenting out those lines. I will put here a patch
for that too, so you could take a look over if you may want.

--
Diana Prajescu
2012/3/18 Lubos Pintes <pintes@gmail.com>:
> Ok now it worked for me. I did the following:
> 1. svn revert -R . for main AbiWord checkout folder and then for msvc2008
> folder.
> 2. Copied strptime.patch to the main AbiWord folder and
> LibAbiWord.vcproj.patch to the msvc2008 folder.
> 3. In main folder: patch -p0 <strptime.patch
> 4. In msvc2008 folder: patch -p0 <LibAbiWord.vcproj.patch
> 5. Patch was applied successfully, build was ok but I received this linker
> error:
> 1>ap_EditMethods.obj : error LNK2019: unresolved external symbol "bool
> __cdecl UT_legalizeFileName(class std::basic_string<char,struct
> std::char_traits<char>,class std::allocator<char> > &)"
> (?UT_legalizeFileName@@YA_NAAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
> referenced in function "bool __cdecl s_AskForPathname(class XAP_Frame
> *,bool,int,char const *,char * *,int *)"
> (?s_AskForPathname@@YA_NPAVXAP_Frame@@_NHPBDPAPADPAH@Z)
>
> Dňa 18. 3. 2012 14:41, Diana Maria Prajescu  wrote / napísal(a):
>
>> Hey,
>>
>> I have reviewed it and it seems that there should be 2 patches:
>> 1) strptime.patch: updates the sources to solve the strptime problem
>> for repo: http://svn.abisource.com/abiword/trunk/. I have created it
>> on the src folder.
>>
>> There is a small problem with it. When I apply the patch to a clean
>> copy of the SVN, the ap_Dialog_Latex.cpp and ut_std_string.cpp aren't
>> patched. I don't understand why.. The error I got when I try to do
>> this is "Rejected patch hunk".
>>
>> 2) LibAbiWord.vcproj.patch: it's the patch which adds the sources from
>> strptime.patch to the solution. I have created it on the msvc2008
>> folder for the repo: http://svn.abisource.com/abiword-msvc2008/trunk/
>>
>> These 2 patches are attached. I would be thankful if anyone can test
>> them and let me know the results.
>>
>> --
>> Many thanks,
>> Diana Prajescu
>>
>> On Sun, Mar 18, 2012 at 1:56 PM, Diana Maria Prajescu
>> <diana.prajescu@gmail.com>  wrote:
>>>
>>> I am reviewing it and come with an answer shortly.
>>>
>>> Many thanks for your feedback.
>>>
>>> --
>>> Diana
>>>
>>> On Sun, Mar 18, 2012 at 1:52 PM, Lubos Pintes<pintes@gmail.com>  wrote:
>>>>
>>>> Hi,
>>>> Is it really necessary to add header files to project? This doesn't
>>>> matter,
>>>> I added it. The error is probably caused by copy/paste error or
>>>> something
>>>> similar:
>>>> Open file ut_strptime.cpp and review lines 44 and 428...
>>>>
>>>> Dňa 18. 3. 2012 11:48, Diana Maria Prajescu  wrote / napísal(a):
>>>>
>>>>> Hello,
>>>>>
>>>>> I know about those errors, I have mentioned them before in the first
>>>>> email. This patch was only for the strptime error. I have managed to
>>>>> solve the other issues but I don't think they should be included in
>>>>> this patch. I will create one for them too.
>>>>>
>>>>> Indeed I have forgoten to add the ut_strptime.cpp and ut_strptime.h to
>>>>> the project in the patch. I will upload a new patch soon.
>>>>>
>>>>> Try adding ut_strptime.cpp and ut_strptime.h to the solution and let
>>>>> me know if you still have ut_strptime errors.
>>>>>
>>>>> Thanks,
>>>>> Diana
>>>>>
>>>>> On Sun, Mar 18, 2012 at 12:34 PM, Lubos Pintes<pintes@gmail.com>
>>>>>  wrote:
>>>>>>
>>>>>> I am not a Windows developer. I am just "building things for fun" and
>>>>>> one
>>>>>> of
>>>>>> such things is AbiWord.
>>>>>> It seems to me (again) that Windows build of AbiWord is broken a bi t
>>>>>> more.
>>>>>> So I applied your patch. Note that it is necessary to add the
>>>>>> ut_strptime.cpp to project, your patch only modifies/adds files to src
>>>>>> directory. After that I received following build errors: (some are not
>>>>>> related to your patch but a brokenness of build itself)
>>>>>> 1>..\..\src\wp\ap\xp\ap_Dialog_Latex.cpp(90) : error C2057: expected
>>>>>> constant expression
>>>>>> 1>..\..\src\wp\ap\xp\ap_Dialog_Latex.cpp(90) : error C2466: cannot
>>>>>> allocate
>>>>>> an array of constant size 0
>>>>>> 1>..\..\src\wp\ap\xp\ap_Dialog_Latex.cpp(90) : error C2133: 'wName' :
>>>>>> unknown size
>>>>>> 1>..\..\src\af\util\xp\ut_strptime.cpp(428) : error C2084: function
>>>>>> 'char
>>>>>> *strptime(const char *,const char *,tm *)' already has a body
>>>>>> 1>..\..\src\af\util\xp\ut_strptime.cpp(434) : error C2084: function
>>>>>> 'char
>>>>>> *_strptime(const char *,const char *,tm *,int)' already has a body
>>>>>> 1>..\..\src\af\util\xp\ut_strptime.cpp(498) : error C3861:
>>>>>> '_strptime':
>>>>>> identifier not found
>>>>>> ... several of them similar as last one
>>>>>>
>>>>>>
>>>>>> Dňa 17. 3. 2012 21:02, Diana Maria Prajescu wrote / napísal(a):
>>>>>>>
>>>>>>> Hello,
>>>>>>>
>>>>>>> I'm looking forward to getting some feedback on the patch I've made.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Diana
>>>>>>>
>>>>>>> On Fri, Mar 16, 2012 at 2:47 AM, Diana Maria Prajescu
>>>>>>> <diana.prajescu@gmail.com>      wrote:
>>>>>>>>
>>>>>>>> Hello!
>>>>>>>>
>>>>>>>> I am Diana Prajescu and I am student in the third year at
>>>>>>>> Politehnica
>>>>>>>> University of Bucharest from Romania. I am interested in applying
>>>>>>>> for
>>>>>>>> one of the project ideas for GSoC. I was trying to "solve the
>>>>>>>> exercise" proposed when I have realized that there is a bug on
>>>>>>>> Windows
>>>>>>>> and the project cannot be built.
>>>>>>>>
>>>>>>>> I have decided to solve it. It is the bug with the id 13284 from the
>>>>>>>> bugzilla list. The patch is attached. The problem is that the
>>>>>>>> function
>>>>>>>> strptime does not exist on Windows and I have solved it using an
>>>>>>>> implementation from NetBSD.
>>>>>>>>
>>>>>>>> I have also noticed that there are some small problems which I had
>>>>>>>> to
>>>>>>>> solve before building the project. Should I send you a description
>>>>>>>> of
>>>>>>>> them together with the solution?
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Diana Prajescu
>>>>>>>
>>>>>>> .
>>>>>>>
>