Re: commit -- win32 version of options dialog

Stephen Hack (shack@uiuc.edu)
Mon, 8 Nov 1999 12:18:49 -0600


--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii

I checked out the NT version and after over an hour build time (so, I
have a slow NT machine, actually, I think it's the OS :), I can not
duplicate the problem.

I did have to change the code some to get it to compile. Some of the
implicit type casting from (void *) to (struct HWND__ *) in
ap_Win32Dialog_Options.cpp were not compiling.

Here's the patch I needed to get the tree to build under NT
patch -p0 <p-99.11.08-1

-shack

On Sun, Nov 07, 1999 at 07:20:28PM -0600, Jeff Hostetler wrote:
>
> I just checked in the beginnings of the win32 version of the
> options dialog to help bring us up even with the unix version
> that Stephen Hack <shack@uiuc.edu> provided.
>
> there are several things missing (like the preferences and view
> tabs) and most of the buttons don't work -- waiting on XP code.
>
> there is a weirdness with the push buttons (dictionary, reset,
> and edit) on the spelling tab (which causes it to lock up tight
> on win98 (i can't remember how many times i've blue-screened
> today...)) -- i appreciate it if someone with NT could take a
> quick look at it.
>
> enjoy,
> jeff

--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="p-99.11.08-1"

? src/WIN32_20.1_i386_DBG
Index: src/wp/ap/win/ap_Win32Dialog_Options.cpp
===================================================================
RCS file: /u2/cvsroot/abi/src/wp/ap/win/ap_Win32Dialog_Options.cpp,v
retrieving revision 1.3
diff -c -r1.3 ap_Win32Dialog_Options.cpp
*** ap_Win32Dialog_Options.cpp 1999/11/08 01:14:37 1.3
--- ap_Win32Dialog_Options.cpp 1999/11/08 18:15:34
***************
*** 280,286 ****
_populateWindowData();

// make sure first tab is selected.
! ShowWindow(m_vecSubDlgHWnd.getNthItem(0), SW_SHOW);

return 1; // 1 == we did not call SetFocus()
}
--- 280,286 ----
_populateWindowData();

// make sure first tab is selected.
! ShowWindow((struct HWND__*) m_vecSubDlgHWnd.getNthItem(0), SW_SHOW);

return 1; // 1 == we did not call SetFocus()
}
***************
*** 513,521 ****

#define DEFINE_GET_SET_BOOL(index,button) \
UT_Bool AP_Win32Dialog_Options::_gather##button(void) \
! { return IsDlgButtonChecked(m_vecSubDlgHWnd.getNthItem(index),AP_RID_DIALOG_OPTIONS_CHK_##button); } \
void AP_Win32Dialog_Options::_set##button(UT_Bool b) \
! { CheckDlgButton(m_vecSubDlgHWnd.getNthItem(index),AP_RID_DIALOG_OPTIONS_CHK_##button,b); }

DEFINE_GET_SET_BOOL(SPELL_INDEX,SpellCheckAsType);
DEFINE_GET_SET_BOOL(SPELL_INDEX,SpellHideErrors);
--- 513,521 ----

#define DEFINE_GET_SET_BOOL(index,button) \
UT_Bool AP_Win32Dialog_Options::_gather##button(void) \
! { return IsDlgButtonChecked((struct HWND__*)m_vecSubDlgHWnd.getNthItem(index),AP_RID_DIALOG_OPTIONS_CHK_##button); } \
void AP_Win32Dialog_Options::_set##button(UT_Bool b) \
! { CheckDlgButton((struct HWND__*)m_vecSubDlgHWnd.getNthItem(index),AP_RID_DIALOG_OPTIONS_CHK_##button,b); }

DEFINE_GET_SET_BOOL(SPELL_INDEX,SpellCheckAsType);
DEFINE_GET_SET_BOOL(SPELL_INDEX,SpellHideErrors);

--Kj7319i9nmIyA2yE--



This archive was generated by hypermail 1.03b2.