Subject: Re: PATCH (4): Insert Symbol again.
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Fri Apr 07 2000 - 23:36:23 CDT
On Sat, 8 Apr 2000, [iso-8859-1] Joaquín Cuenca Abela wrote:
Hi Joaquin,
Thanks very much for the hard work you've put into this patch.
You've almost fixed the flicker problem. It is much better than how I left
it. I gave up putting more work on the flicker problem since I didn't
think it was fixable with the present abi drawing code. You've shown
otherwise! Though as you say the real solution would be to do double
buffering.
However there are some serious problems with the new patch.
1. The table showing all the symbols shows the selected font but for
actually selecting something inserts the present font from the main view.
for example. Select Times New Roman in the main view of the document.
Select "Standard Symbols" in "insert Symbol". Choose a symbol. The
chosen symbol is the "Times New Roman" equivalent character in the
Selected Symbol area. The symbol that goes into the text is a "Times New
Roman" symbol - not the selected symbol from the "Standard Symbols" map.
2. The font and selected symbol are no longer persistant across
invocations.
Both of these used to work. I will try to fix these while keeping
your flicker freer code. I hope to have a new patch by Monday.
Thanks for your work on this! I clearly have a lot to learn.
Cheers
Martin
> Martin Sevior wrote:
> >
> > Hi everyone,
> > Thanks very much to Joaquin for looking over the previous
> > "Insert Symbol" patch. This latest patch has a number of improvements.
> >
> > 1. Works against the current source tree as opposed to the source tree of
> > 6 weeks ago.
> >
> > 2. Stupid crash on exit of abiword bug fixed.
> >
> > 3. Label for "Insert Symbol" is internationalized the correct way.
> >
> > 4. Font size for the array of symbols has been increased to "14" from the
> > previous 10. Joaquin complained that "10" was too hard to read for some
> > symbols. We have to trade off size of dialog for readability.
> >
> > 5. Pressing the arrow keys no longer appears to select different elements
> > of the dialog. (Thanks very much Joaquin for the gtk tip!)
>
> Martin, I've been playing with your patch, and I've made a number of
> little improvements:
>
> 1. I've made the ok button activable with [ENTER].
>
> 2. I've changed the way you were blocking the key_press event. You only
> have to block the event if you were processing the pressed key (if the
> pressed key is an arrow). If you don't use the pressed key, you have to
> left the event propagation (for example, if the user press [ENTER] and
> you block the signal, nobody is going to hear [ENTER]).
>
> 3. I've changed the order of (and erased) some instructions to avoid
> some unnecesary flicker (I've needed 5 hours with gdb to find the
> correct order and the unnecesary instructions).
>
> 4. I've speeded up the code to draw the grid and I've added a new
> gr_UnixGraphics to speeded up the draw of a single character. This
> change made the remaining flicker invisible in my computer and correct a
> little error due to rounding problems (but the final solution to the
> flicker problem is the double buffering).
>
> 5. I've corrected the indentation.
>
> There are a number of unresolved problems:
>
> 1. The gtk+ layout is sub-optimal (in particular, the ok/cancel buttons
> are too big and I think that the combo box has to be changed for a
> option menu)
>
> 2. The selected font and the selected symbol are not persistent.
>
> 3. The default font of the dialog box is "Standard Symbols", that has
> too few visible characters (?). Maybe the default font has to be the
> current font.
>
> 4. The _constructWindow has to be splited in
> _constructWindow/_constructWindowContents to make the gnome port more
> easy (I will look at this the monday).
>
> Even with these problems, the dialog is more than acceptable, Martin has
> done a wonderful work with this dialog and I don't see any reason to
> leave the dialog out of cvs.
>
> Does anybody complain if I commit the Insert Symbol dialog box? (to
> date, I've only used my cvs write permission to commit gnome-related or
> LaTeX-related code, and I want to know if I have permission to commit
> gtk+ only code)
>
> And now, the patch :)
>
> P.S.: I will leave the city for two days. If the monday I don't see any
> problem, I will commit the dialog.
>
> --
> Joaquín Cuenca Abela
> e-mail: cuenca@ie2.u-psud.fr
This archive was generated by hypermail 2b25 : Mon Apr 10 2000 - 11:33:30 CDT