Subject: Re: patch -- -to command line option (3rd. round ;)
From: Joaquín Cuenca Abela (cuenca@ie2.u-psud.fr)
Date: Sun Feb 27 2000 - 14:41:25 CST
Robert Sievers wrote:
>
> At 07:45 PM 2/17/00 +0100, Joaquín Cuenca Abela wrote:
> >Ok, that's "the definitive --to command line option patch" (tm).
> >
> >It has no differences in the gnome and xp fronts, and it "implements"
> >this options in the gtk, win32 and BeOS systems.
>
> Ok, I have had a chance to look at this, and have 3 comments.
>
> 1. The patch does not build on Windows. There is no glib.h on Windows,
> therefore the call at line 25 of ap_convert.cpp fails.
Stupid cut & paste bug... I've just forgotted it, you can erase this
line without any problem (there is no need for glib in the
ap_Convert.cpp file).
>
> 2. On linux, the -verbose option causes the splash screen to appear. This
> should not happen.
?? I can't reproduce that (in the gnome platform... I'm recompiling
the gtk platform right now)
Can you say me your entire command line?
>
> 3. Shouldn't information on these options appear when I do AbiWord_d -help?
Of course, I forgotted to add the help, too.
Here you a mini patch to solve the first and the third problem (in the
gtk platform).
-- Joaquín Cuenca Abela e-mail: cuenca@ie2.u-psud.fr
diff -ru --exclude=*~ --exclude=*CVS* abi/src/wp/ap/unix/ap_UnixApp.cpp abi2/src/wp/ap/unix/ap_UnixApp.cpp --- abi/src/wp/ap/unix/ap_UnixApp.cpp Sun Feb 27 21:34:06 2000 +++ abi2/src/wp/ap/unix/ap_UnixApp.cpp Sun Feb 27 21:28:38 2000 @@ -1010,7 +1010,9 @@ { // just print to stdout, not stderr printf("\nUsage: %s [option]... [file]...\n\n", m_pArgs->m_argv[0]); - + printf(" -to The target format of the file (abw, zabw, rtf, txt, utf8, html, latex)"); + printf(" -verbose The verbosity level (0, 1, 2)"); + printf(" -show If you really want to start the GUI (even if you use the --to option)"); #ifdef DEBUG printf(" -dumpstrings dump strings strings to file\n"); #endif diff -ru --exclude=*~ --exclude=*CVS* abi/src/wp/ap/xp/ap_Convert.cpp abi2/src/wp/ap/xp/ap_Convert.cpp --- abi/src/wp/ap/xp/ap_Convert.cpp Sun Feb 27 21:34:06 2000 +++ abi2/src/wp/ap/xp/ap_Convert.cpp Sun Feb 27 21:25:08 2000 @@ -22,7 +22,6 @@ #include "ap_Convert.h" #include "ie_exp.h" -#include "glib.h" #include "ut_types.h" //////////////////////////////////////////////////////////////////
This archive was generated by hypermail 2b25 : Sun Feb 27 2000 - 14:41:30 CST