Subject: Re: Commit: Beta version of Lists, Lists Dialog and bug fixes.
From: Thomas Fletcher (thomasf@qnx.com)
Date: Fri Jul 07 2000 - 05:58:00 CDT
Martin,
I just patched in some code to cast away a const in fl_AutoNum.cpp
that you committed. I thought it might be list related (but in
retrospect now I don't think so). In any case you might want to
check and see that casting this const away is valid, otherwise
we should change the code (getType) to return a const pointer
and not a plain pointer. People please take care in this regard.
const is there for a reason ... if you are just going to do
away with it, then don't use it in the first place!
Sigh ... Once again we cast away the const.
DANGER WILL ROBINSON: This may have serious repercussions later on
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: fl_AutoNum.cpp
CVS: ----------------------------------------------------------------------
On Fri, 7 Jul 2000, Martin Sevior wrote:
>
> On Fri, 7 Jul 2000, Martin Sevior wrote:
>
> >
> > The list code will only be invoked in debug builds since we use fields for
> > list labels. Bullets don't work at all right now. We really need better
>
> Whoops! The non-debug build is broken coz of a stupid error in
> ap_EditMethods.cpp. This new commit fixes this.
>
> I should not need to buy donuts though because everyone is working on the
> debug build right ? :-)
>
> Cheers
>
> Martin
>
>
> CVS:
> ----------------------------------------------------------------------
> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
> CVS:
> CVS: Committing in .
> CVS:
> CVS: Modified Files:
> CVS: src/wp/ap/xp/ap_EditMethods.cpp
> CVS:
> ----------------------------------------------------------------------
>
> Fix for the non-debug build. Tinderbox should become green.
>
>
>
This archive was generated by hypermail 2b25 : Fri Jul 07 2000 - 05:58:07 CDT