Subject: Re: libole2
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Wed Jun 07 2000 - 08:05:39 CDT
On Tue, 6 Jun 2000, Eric W. Sink wrote:
>
> Then I saw some discussion about this code causing a huge slowdown in
> the Word importer, and yet the consensus for a commit still appeared
> quite strong.
>
Sorry for the confusion. I had seen that slowdown on the file on a
previous wv and in fact a previous wv had crashed abi on a file that the
new wv now gracefully refuses to load. That's some progress I guess :-)
In any case I have a staple of difficult *.doc files and the new wv did no
worse that the old and in some cases better.
> Now, this particular fragment of code is irking me, because it
> completely breaks the Windows build, so I'm wondering about its
> purpose.
>
> Am I missing something? :-)
>
> For the record, this code appears to simply not even compile under
> Windows. I suspect that it was never compiled under Win32 before it
> was checked in. The current build problem is the non-presence of
> mode_t on that platform, but we are likely to encounter other problem
> before this code gets back to the functionality we had before.
>
>
We have at least the same functionality under linux. I see no reason why
we won't eventually have the same functionality under windows. The patch
was up for all to see for about 5 days and no one objected. That being the
case I should have insisted that it be tested under Windows before
committing.
I've learnt my lesson. I'm sorry. I won't do major commits without wider
testing again.
Martin
This archive was generated by hypermail 2b25 : Wed Jun 07 2000 - 08:05:55 CDT