patch: insane code - locales


Subject: patch: insane code - locales
From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Sun Apr 08 2001 - 20:26:01 CDT


I found the following code in the source; it seems to make no sense at all
- we don't do an iconv_reset, ever, unless we're in a
cjk_locale(). Here's a diff that corrects this seemingly anomalous
situation, unless someone can tell me why that if is there.

pat

Index: src/af/xap/xp/xap_EncodingManager.cpp
===================================================================
RCS file: /cvsroot/abi/src/af/xap/xp/xap_EncodingManager.cpp,v
retrieving revision 1.25
diff -u -r1.25 xap_EncodingManager.cpp
--- src/af/xap/xp/xap_EncodingManager.cpp 2001/02/06 22:54:25 1.25
+++ src/af/xap/xp/xap_EncodingManager.cpp 2001/04/09 01:20:59
@@ -955,6 +955,5 @@
 
 void UT_iconv_reset(iconv_t cd)
 {
- if (XAP_EncodingManager::instance->cjk_locale())
- iconv(cd,const_cast<ICONV_CONST char**>((char**)NULL),NULL,NULL,NULL);
+ iconv(cd,const_cast<ICONV_CONST char**>((char**)NULL),NULL,NULL,NULL);
 };



This archive was generated by hypermail 2b25 : Sun Apr 08 2001 - 20:29:24 CDT