Subject: Re: patch: insane code - locales
From: Vlad Harchev (hvv@hippo.ru)
Date: Mon Apr 09 2001 - 00:03:31 CDT
On Sun, 8 Apr 2001, Patrick Lam wrote:
Hi,
The code is necessary - the iconv from libiconv dies in SIGSEGV sometimes if
all arguments beside it are not NULL (that's a valid usage for iconv). We have
no option beside this ugly hack or fixing iconv from libiconv by ourselves.
> I found the following code in the source; it seems to make no sense at all
> - we don't do an iconv_reset, ever, unless we're in a
> cjk_locale(). Here's a diff that corrects this seemingly anomalous
> situation, unless someone can tell me why that if is there.
>
> pat
>
> Index: src/af/xap/xp/xap_EncodingManager.cpp
> ===================================================================
> RCS file: /cvsroot/abi/src/af/xap/xp/xap_EncodingManager.cpp,v
> retrieving revision 1.25
> diff -u -r1.25 xap_EncodingManager.cpp
> --- src/af/xap/xp/xap_EncodingManager.cpp 2001/02/06 22:54:25 1.25
> +++ src/af/xap/xp/xap_EncodingManager.cpp 2001/04/09 01:20:59
> @@ -955,6 +955,5 @@
>
> void UT_iconv_reset(iconv_t cd)
> {
> - if (XAP_EncodingManager::instance->cjk_locale())
> - iconv(cd,const_cast<ICONV_CONST char**>((char**)NULL),NULL,NULL,NULL);
> + iconv(cd,const_cast<ICONV_CONST char**>((char**)NULL),NULL,NULL,NULL);
> };
>
Best regards,
-Vlad
This archive was generated by hypermail 2b25 : Mon Apr 09 2001 - 00:45:50 CDT