Subject: Re: Code problems found by doxygen
From: Paul Rohr (paul@abisource.com)
Date: Wed Feb 07 2001 - 13:15:52 CST
At 04:15 PM 2/4/01 GMT, Jesper Skov wrote:
>A pile of these this time. Don't know if anyone feels up to fixing
>some of them.
Thanks, Jesper.
If anyone is interested in doing a little "code janitor" work, this actually
looks like a small set of related problems:
1. improperly stubbed dialogs
------------------------------
Insofar as these dialogs aren't finished on any platform yet (AFAIK), this
is unfortunate, but not surprising. (I'm not hugely in love with the
set/gather paradigm, but it certainly highlights stubbing mistakes.)
abi/src/wp/ap/beos/ap_BeOSDialog_Options.cpp
abi/src/wp/ap/mac/ap_MacDialog_Options.cpp
abi/src/wp/ap/qnx/ap_QNXDialog_Options.cpp
abi/src/wp/ap/qnx/ap_QNXDialog_Tab.cpp
abi/src/wp/ap/unix/ap_UnixDialog_Options.cpp
abi/src/wp/ap/unix/ap_UnixDialog_Tab.cpp
abi/src/wp/ap/win/ap_Win32Dialog_Options.cpp
abi/src/wp/ap/win/ap_Win32Dialog_Tab.cpp
Before fixing these warnings, we should find someone to finish the XP dialog
on their platform of choice.
2. AP_UnixGnomeDialogFactory
-----------------------------
I don't know whether the ctor/dtor of this class is even used.
abi/src/wp/ap/unix/gnome/ap_UnixGnomeDialogFactory.cpp
3. prototype mismatch for impexp insertStrux?
----------------------------------------------
OK, C++ whizzes, is the void (*) vs void (* pfnBindHandles) "mismatch" a
Doxygen flaw, or did we just cut&paste a broken declaration to all the
exporters?
abi/src/wp/impexp/xp/ie_exp_AbiWord_1.cpp
abi/src/wp/impexp/xp/ie_exp_DocBook.cpp
abi/src/wp/impexp/xp/ie_exp_HTML.cpp
abi/src/wp/impexp/xp/ie_exp_LaTeX.cpp
abi/src/wp/impexp/xp/ie_exp_MsWord_97.cpp
abi/src/wp/impexp/xp/ie_exp_Psion.cpp
abi/src/wp/impexp/xp/ie_exp_RTF_listenerGetProps.cpp
abi/src/wp/impexp/xp/ie_exp_RTF_listenerWriteDoc.cpp
abi/src/wp/impexp/xp/ie_exp_Text.cpp
abi/src/wp/impexp/xp/ie_exp_UTF8.cpp
abi/src/wp/impexp/xp/ie_exp_WML.cpp
4. real stuff
--------------
These are obvious.
>/local/jskov/abi/abi/src/wp/impexp/xp/ie_exp_PalmDoc.cpp:378: Warning: no
matching class member found for
> void IE_Exp_PalmDoc::_zero_fill(register char * p,register int len)
>Possible candidates:
> void _zero_fill( char*, int len )
>/local/jskov/abi/abi/src/wp/impexp/xp/ie_exp_PalmDoc.cpp:384: Warning: no
matching class member found for
> Byte * IE_Exp_PalmDoc::_mem_find(register Byte * t,int t_len,register
Byte * m,int m_len)
>Possible candidates:
> Byte* _mem_find( Byte *t, int t_len, Byte *m, int m_len )
>/local/jskov/abi/abi/src/wp/impexp/xp/ie_imp_MSWrite.cpp:499: Warning: no
matching class member found for
> UT_uint32 IE_Imp_MSWrite::ReadText(FILE * file,const
WRI_write_file_desc_t & desc,UT_uint16 pageNumber,UT_Byte * buf,size_t &
bufLen)
>Possible candidates:
> UT_uint32 ReadText(FILE * file, const WRI_write_file_desc_t & desc,
UT_uint16 pageNumber, UT_Byte * buf, UT_uint32 & bufLen)
Paul
This archive was generated by hypermail 2b25 : Wed Feb 07 2001 - 13:10:19 CST