Subject: Re: Commit: Idle, Spellcheck, FileImport
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Wed Sep 19 2001 - 20:44:30 CDT
On Wed, 19 Sep 2001, Dom Lachowicz wrote:
> UnixIdle changed so that it no longer uses gtk_idles but g_idles as well as some
> liberal UT_ASSERTs sprinkled around the code. This helped me track down the next
> bug:
HI Dom,
There is a fundamental issue with ut_unixIdle. Once started it
will never stop and make Abi consume 100% CPU time. Consequently we have
to make sure the background spellchecking is stopped if the queue become
empty.
Right now abi comsumes 100% CPU time. Ben Mesmen's orginal patch got
around this problem.
I'll see what can be done.
Cheers
Martin
>
> fl_DocLayout was calling pTimer->start on every queued block. This is a wrong
> assumption, as the timer should poll the queue every N seconds. If this breaks
> timer-based implementations, please let me know so I can do the appropriate fix.
>
> Added a member variable in the piecetable to force-mark documents as dirty. This
> was needed to fix the next few bugs:
>
> File->Import was broken mostly. Now import imports a file and marks the doc as
> dirty, thus prompting you to change your fixes. Import before also didn't
> increment the Untitled count. It does now, and newly imported documents open up
> in their own window.
>
> PLATFORM MAINTAINERS: look at the diff to AP_UnixFrame.cpp and do the same thing
> in your impls.
>
> Dom
>
> CVS: ----------------------------------------------------------------------
> CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
> CVS:
> CVS: Committing in .
> CVS:
> CVS: Modified Files:
> CVS: src/af/util/unix/ut_unixIdle.cpp
> CVS: src/text/fmt/xp/fl_DocLayout.cpp
> CVS: src/text/ptbl/xp/pd_Document.cpp
> CVS: src/text/ptbl/xp/pd_Document.h
> CVS: src/text/ptbl/xp/pt_PieceTable.cpp
> CVS: src/wp/ap/unix/ap_UnixFrame.cpp
> CVS: src/wp/ap/xp/ap_EditMethods.cpp
> CVS: ----------------------------------------------------------------------
>
>
This archive was generated by hypermail 2b25 : Wed Sep 19 2001 - 20:44:38 CDT