From: Tomas Frydrych (tomas@frydrych.uklinux.net)
Date: Sun Apr 21 2002 - 12:44:43 EDT
Hi Martin,
overall it looks pretty good to me. Just a couple of
suggestions/questions:
> I propose this:
>
> fp_Run --> lots of run subclasses.
> fp_ContainerObject----|
> |-----> fp_Line
> |-----> fp_Container ----|
> |---> fp_Column
> |->fp_ShadowColumn
> |->fp_PositionedColumn
> |-----> fp_HdrFtrContainer
> |-----> fp_EndNoteContainer
> |-----> fp_FootnoteContainer
> |-----> fp_TableContainer
> |-----> fp_CellContainer
> |-----> fp_RowContainer
>
why not just:
fp_Container----|
|-----> fp_Line
|-----> fp_HdrFtrContainer
|-----> fp_EndNoteContainer
|-----> fp_FootnoteContainer
|-----> fp_TableContainer
|-----> fp_CellContainer
|-----> fp_RowContainer
and
fp_Column--------|
|->fp_ShadowColumn
|->fp_PositionedColumn
It seems to me that since column is the only class that can be
embeded in the page, it would be better as a separate class from
the containers that get embeded into columns (unless we are
expecting to be embeding columns into columns). Also, why does
a line to be a special case, why not just a container like the rest?
Tomas
This archive was generated by hypermail 2.1.4 : Sun Apr 21 2002 - 12:49:44 EDT