Re: commit: wv: lots more from Vladimir

From: Robert Wilhelm (robert@gaston.camelot.de)
Date: Sat Mar 23 2002 - 16:08:05 EST

  • Next message: David Bolack: "Re: [AbiCalc] Spreadsheet proposal"

    On Sat, Mar 23, 2002 at 02:32:13PM +0000, F J Franklin wrote:
    > - ms-ole.c (IMHO lseek must decriment pointer)
    >

    This patch is IMHO wrong, at least Unix lseek and fseek
    add the offset, and do NOT substract it.

    diff -Naur wv/libole2/ms-ole.c wv.mod/libole2/ms-ole.c
    --- wv/libole2/ms-ole.c Thu Mar 14 20:54:22 2002
    +++ wv.mod/libole2/ms-ole.c Sat Mar 23 15:00:17 2002
    @@ -2182,7 +2182,7 @@
             else if (type == MsOleSeekCur)
                     newpos = s->position + bytes;
             else
    - newpos = s->size + bytes;
    + newpos = s->size - bytes;
     
             if (newpos > (MsOleSPos) s->size || newpos < 0) {
                     g_warning ("Invalid seek");

    This archive was generated by hypermail 2.1.4 : Sat Mar 23 2002 - 16:16:04 EST