Re: commit: refactored frame code

From: Hubert Figuiere (hfiguiere@teaser.fr)
Date: Fri Nov 22 2002 - 12:22:12 EST

  • Next message: Mike Nordell: "commit: MSVC6/*"

    On vendredi, nov 22, 2002, at 06:10 Europe/Paris, William Lachance
    wrote:

    > Unix-only for now, conditional compilation of XAP_Frame for other
    > platforms. This requires some explanation:

    That is a great news.
    >
    > As some of you know, the old frame inheritance hierarchy was a bit of a
    > mess.
    >
    > We had
    > XAP_Frame -> XAP_XXXFrame -> AP_XXXFrame
    >
    > (where XXX is Win32, Unix, Qnx)
    >
    > This resulted in plenty of duplicated code in AP_XXXFrame, because we
    > couldn't properly place stuff that wasn't platform independant in an
    > application independant AP_Frame class.
    >
    > The new code in CVS is the start of a new frame hierarchy. Now we have:
    >
    > XAP_Frame -> AP_Frame -> AP_XXXFrame
    >
    > and
    >
    > XAP_FrameHelper --> XAP_XXXFrameHelper -> AP_XXXFrameHelper
    >

    Almost what I want although I would have name the class "Impl" and not
    "Helper" because it really is the implementation. But never mind. That
    is just being nitpicky.

    > The good news: This will ultimately result in less duplicated code (I
    > haven't started placing platform-independant abi frame code into
    > AP_Frame class, I will soon!) and better model-view-controller
    > seperation (it should be somewhat easier to grok the frame code when
    > this is all finished).

    YUM. Now the game is to intermix Cocoa Obj-C MVC model with Abi C++ MVC
    model for the Cocoa port. Fun thing.

    > Overall, I think this is a win. I will continue to polish the XP and
    > UNIX code to make it better. I will need help from platform maintainers
    > to bring the Win32/QNX code to this new system.
    >

    Perhaps we can close that "early" (aka 3 digits) bug soon :-)

    Will, I'm 100% with you and will try to follow the UNIX implementation.

    Hub



    This archive was generated by hypermail 2.1.4 : Fri Nov 22 2002 - 17:01:10 EST