Re: commit: Split Cells, Format Frame Dialogs, table fixes.

From: Ryan Pavlik (rpavlik_at_ryand.cjb.net)
Date: Sun Nov 23 2003 - 14:30:52 EST

  • Next message: Ryan Pavlik: "Win32 Screen Shots for CVS"

    msevior_at_physics.unimelb.edu.au wrote:

    >CVS: ----------------------------------------------------------------------
    >CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    >CVS:
    >CVS: Committing in .
    >CVS:
    >CVS: Modified Files:
    >CVS: src/text/fmt/xp/fl_ContainerLayout.cpp
    >CVS: src/text/fmt/xp/fl_ContainerLayout.h
    >CVS: src/text/fmt/xp/fl_TableLayout.cpp
    >CVS: src/text/fmt/xp/fp_TableContainer.cpp
    >CVS: src/text/fmt/xp/fp_TableContainer.h
    >CVS: src/text/fmt/xp/fv_View.cpp src/text/fmt/xp/fv_View.h
    >CVS: src/text/fmt/xp/fv_View_cmd.cpp
    >CVS: src/text/ptbl/xp/pp_Property.cpp
    >CVS: src/text/ptbl/xp/pp_Property.h src/wp/ap/Makefile
    >CVS: src/wp/ap/cocoa/ap_CocoaDialog_All.h src/wp/ap/qnx/Makefile
    >CVS: src/wp/ap/qnx/ap_QNXDialog_All.h src/wp/ap/unix/GNUmakefile.am
    >CVS: src/wp/ap/unix/Makefile src/wp/ap/unix/ap_UnixDialog_All.h
    >CVS: src/wp/ap/unix/ap_UnixDialog_FormatTable.glade
    >CVS: src/wp/ap/win/Makefile src/wp/ap/win/ap_Win32Dialog_All.h
    >CVS: src/wp/ap/win/ap_Win32Dialog_FormatTable.h
    >CVS: src/wp/ap/xp/GNUmakefile.am src/wp/ap/xp/Makefile
    >CVS: src/wp/ap/xp/ap_Dialog_Id.h src/wp/ap/xp/ap_EditMethods.cpp
    >CVS: src/wp/ap/xp/ap_LB_Default.cpp
    >CVS: src/wp/ap/xp/ap_Menu_ActionSet.cpp
    >CVS: src/wp/ap/xp/ap_Menu_Functions.cpp
    >CVS: src/wp/ap/xp/ap_Menu_Functions.h
    >CVS: src/wp/ap/xp/ap_Menu_Layouts_MainMenu.h
    >CVS: src/wp/ap/xp/ap_String_Id.h
    >CVS: src/wp/ap/xp/ap_TB_Layouts_TableOps.h
    >CVS: src/wp/ap/xp/ap_Toolbar_ActionSet.cpp
    >CVS: src/wp/ap/xp/ap_Toolbar_Functions.cpp
    >CVS: src/wp/ap/xp/ap_Toolbar_Functions.h
    >CVS: src/wp/ap/xp/ap_Toolbar_Icons_All.h
    >CVS: src/wp/ap/xp/ap_TopRuler.cpp
    >CVS: Added Files:
    >CVS: shots/wp/unix/FormatFrame.png shots/wp/unix/SplitCells.png
    >CVS: src/wp/ap/cocoa/ap_CocoaDialog_FormatFrame.h
    >CVS: src/wp/ap/cocoa/ap_CocoaDialog_SplitCells.h
    >CVS: src/wp/ap/qnx/ap_QNXDialog_FormatFrame.cpp
    >CVS: src/wp/ap/qnx/ap_QNXDialog_FormatFrame.h
    >CVS: src/wp/ap/qnx/ap_QNXDialog_SplitCells.cpp
    >CVS: src/wp/ap/qnx/ap_QNXDialog_SplitCells.h
    >CVS: src/wp/ap/unix/ap_UnixDialog_FormatFrame.cpp
    >CVS: src/wp/ap/unix/ap_UnixDialog_FormatFrame.glade
    >CVS: src/wp/ap/unix/ap_UnixDialog_FormatFrame.h
    >CVS: src/wp/ap/unix/ap_UnixDialog_SplitCells.cpp
    >CVS: src/wp/ap/unix/ap_UnixDialog_SplitCells.h
    >CVS: src/wp/ap/win/ap_Win32Dialog_FormatFrame.cpp
    >CVS: src/wp/ap/win/ap_Win32Dialog_FormatFrame.h
    >CVS: src/wp/ap/win/ap_Win32Dialog_SplitCells.cpp
    >CVS: src/wp/ap/win/ap_Win32Dialog_SplitCells.h
    >CVS: src/wp/ap/xp/ap_Dialog_FormatFrame.cpp
    >CVS: src/wp/ap/xp/ap_Dialog_FormatFrame.h
    >CVS: src/wp/ap/xp/ap_Dialog_SplitCells.cpp
    >CVS: src/wp/ap/xp/ap_Dialog_SplitCells.h
    >VS: src/wp/ap/xp/ToolbarIcons/tb_SplitAbove.xpm
    >CVS: src/wp/ap/xp/ToolbarIcons/tb_SplitBelow.xpm
    >CVS: src/wp/ap/xp/ToolbarIcons/tb_SplitHoriMid.xpm
    >CVS: src/wp/ap/xp/ToolbarIcons/tb_SplitLeft.xpm
    >CVS: src/wp/ap/xp/ToolbarIcons/tb_SplitRight.xpm
    >CVS: src/wp/ap/xp/ToolbarIcons/tb_SplitVertMid.xpm
    >CVS: ----------------------------------------------------------------------
    >Split Cells and Format Frame dialogs plus some table fixes. Format Frame
    >isn't finished.
    >
    >See the screen shots commited to the shots directory for what these
    >dialogs looks like. They're both Modeless. The SplitCells dialogs looks
    >similar to
    >the MergeCell dialog but there are 6 buttons now. (split top, middle,
    >bottom, split left, middle, right). The splitcells dialogs is only active
    >on cells with one or more merged rows/columns. The dialog will only let
    >you split rows/columns that are merged.
    >
    >There is one last bug to be fixed. That is the cursor doesn't go into the
    >correct cell after a split.
    >
    >The FormatFrame dialog right now is just a copy/paste of the format Table
    >dialogs with some appropriate changes. The backend to actually apply the
    >change hasn't been written yet. I will do this very soon.
    >
    >I have implemented SplitCells and FormatFrames on Win32, Cocoa and QNX but
    >simply copying the MergeCells and FormatTable dialogs with some changes
    >that will hopefully allow them to compile. However I haven't tested them
    >so I've almost certainly broken the build on Win32, QNX and Cocoa.
    >
    >Sorry.
    >
    >Please fix to get them to compile then examine the screenshots to see how
    >you might like to implement the dialogs in your platform. Because of the
    >similarity with the MergeCell and FormatTame dialogs I expect it won't be
    >too hard to get these going.
    >
    >Finally I fixed some Table Bugs caused by our binary search for cell
    >algorithmin. Unfortunately this doesn;t work for many types of
    >mergedCells.
    >I've implemented a boring and slow Linear search for cells if the binary
    >cell search fails.
    >
    >Anyway, Enjoy our New Features :-)
    >Cheers
    >
    >Martin
    >
    >
    >
    >
    Yup, win32 compile broken. It croaks in ap_Win32Dialog_FormatFrame.cpp.
    I'll see if I can figure out what's wrong, but I'm doubting I can find
    it. Here's my build messages from there, in case that help someone
    who's more familiar with this code.
    ap_Win32Dialog_FormatTable.cpp:
    ap_Win32Dialog_FormatFrame.cpp:
    ap_Win32Dialog_FormatFrame.cpp: In member function `virtual BOOL
       AP_Win32Dialog_FormatFrame::_onInitDialog(HWND__*, unsigned int, long
    int)':
    ap_Win32Dialog_FormatFrame.cpp:168: `AP_STRING_ID_DLG_FormatFrame_Apply_To'
       undeclared (first use this function)
    ap_Win32Dialog_FormatFrame.cpp:168: (Each undeclared identifier is reported
       only once for each function it appears in.)
    ap_Win32Dialog_FormatFrame.cpp:202: `
       AP_STRING_ID_DLG_FormatFrame_Apply_To_Selection' undeclared (first
    use this
       function)
    ap_Win32Dialog_FormatFrame.cpp:205:
    `AP_STRING_ID_DLG_FormatFrame_Apply_To_Row'
       undeclared (first use this function)
    ap_Win32Dialog_FormatFrame.cpp:208: `
       AP_STRING_ID_DLG_FormatFrame_Apply_To_Column' undeclared (first use this
       function)
    ap_Win32Dialog_FormatFrame.cpp:211: `
       AP_STRING_ID_DLG_FormatFrame_Apply_To_Table' undeclared (first use this
       function)
    ap_Win32Dialog_FormatFrame.cpp: In member function `virtual BOOL
       AP_Win32Dialog_FormatFrame::_onCommand(HWND__*, unsigned int, long int)':
    ap_Win32Dialog_FormatFrame.cpp:336: `_FormatFrame' undeclared (first use
    this
       function)
    ap_Win32Dialog_FormatFrame.cpp:336: parse error before `)' token
    make[4]: ***
    [/d/src/abiroot/abi/src/MINGW32_1.0.9_i386_OBJ/obj/ap_Win32Dialog_FormatFrame.o]
    Error 1
    make[4]: Leaving directory `/d/src/abiroot/abi/src/wp/ap/win'
    make[3]: *** [build] Error 2
    make[3]: Leaving directory `/d/src/abiroot/abi/src/wp/ap'
    make[2]: *** [build] Error 2
    make[2]: Leaving directory `/d/src/abiroot/abi/src/wp'
    make[1]: *** [build] Error 2
    make[1]: Leaving directory `/d/src/abiroot/abi/src'
    make: *** [compile] Error 2

    Administrator_at_QUENYA /d/src/abiroot/abi

    Ryan
    (using latest CVS, mingw, msys w/win32api 2.3 as directed by S.V.)



    This archive was generated by hypermail 2.1.4 : Sun Nov 23 2003 - 14:35:02 EST