Re: patch: resizing to meet localisation need

From: Dom Lachowicz (domlachowicz@yahoo.com)
Date: Wed Sep 03 2003 - 15:56:16 EDT

  • Next message: Hubert Figuiere: "Re: and I was called paranoid and FUD-monger..."

    Patch looks good, considering that Win32's lowlevel
    controls doesn't really support a "box" layout model.

    Please commit this, so long as the dialogs look ok in
    English too.

    Dom

    --- Jordi Mas <jmas@softcatala.org> wrote:
    > As you probably know most controls in Win32 does not
    > resize automatically.
    > Since, most localised versions have up 30% longer
    > texts you get some controls
    > that can display properly the English text (because
    > it's shorter) but some
    > localised versions shown cut text.
    >
    > I have tested Spanish and German that are pretty
    > large languages and I have
    > size some controls to allow the text to fit
    > properly. This is very common when
    > you work with localised version.
    >
    > Requesting OK to commit.
    >
    > Thanks,
    >
    > --
    >
    > Jordi Mas i Hernāndez - Abiword developer -
    > http://www.abisource.com
    > jmas@softcatala.org - Softcatalā member -
    > http://www.softcatala.org
    > - Personal Homepage
    > http://www.softcatala.org/~jmas
    > > Index: src/af/xap/win/xap_Win32Res_DlgPlugin.rc2
    >
    ===================================================================
    > RCS file:
    >
    /cvsroot/abi/src/af/xap/win/xap_Win32Res_DlgPlugin.rc2,v
    > retrieving revision 1.6
    > diff -u -r1.6 xap_Win32Res_DlgPlugin.rc2
    > --- src/af/xap/win/xap_Win32Res_DlgPlugin.rc2 12 Aug
    > 2003 12:35:59 -0000 1.6
    > +++ src/af/xap/win/xap_Win32Res_DlgPlugin.rc2 3 Sep
    > 2003 19:51:39 -0000
    > @@ -68,12 +68,12 @@
    > WS_VSCROLL | WS_HSCROLL | WS_TABSTOP
    >
    > PUSHBUTTON "Deactivate Plugin",
    > -
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_BTN_DEACTIVATE,8,157,96,14
    > +
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_BTN_DEACTIVATE,8,157,116,14
    >
    > PUSHBUTTON "Deactivate All Plugins",
    > -
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_BTN_DEACTIVATEALL,8,175,96,
    > 14
    > +
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_BTN_DEACTIVATEALL,8,175,116,
    > 14
    > PUSHBUTTON "Install New Plugin",
    > -
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_BTN_INSTALL,8,193,96,14
    > +
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_BTN_INSTALL,8,193,116,14
    > EDITTEXT
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_EBX_NAME,138,40,151,14,
    > ES_AUTOHSCROLL | ES_READONLY
    > EDITTEXT
    >
    XAP_RID_DIALOG_PLUGIN_MANAGER_EBX_DESCRIPTION,138,73,151,
    > Index: src/wp/ap/win/ap_Win32Res_DlgInsertTable.rc2
    >
    ===================================================================
    > RCS file:
    >
    /cvsroot/abi/src/wp/ap/win/ap_Win32Res_DlgInsertTable.rc2,v
    > retrieving revision 1.4
    > diff -u -r1.4 ap_Win32Res_DlgInsertTable.rc2
    > --- src/wp/ap/win/ap_Win32Res_DlgInsertTable.rc2 20
    > Jun 2003 15:26:30 -0000 1.4
    > +++ src/wp/ap/win/ap_Win32Res_DlgInsertTable.rc2 3
    > Sep 2003 19:51:56 -0000
    > @@ -73,13 +73,13 @@
    > LTEXT "Number of
    > rows:",AP_RID_DIALOG_INSERTTABLE_TEXT_ROW,13,
    > 42,92,12
    > LTEXT "Table
    > size",AP_RID_DIALOG_INSERTTABLE_TEXT_SIZE,5,5,
    > - 37,8
    > + 80,8
    > CONTROL
    > "",AP_RID_DIALOG_STYLES_TOP_TEXT_DEFAULT,"Static",
    > SS_BLACKFRAME |
    > SS_SUNKEN,5,61,195,1
    > LTEXT "Autofit
    > behavior",AP_RID_DIALOG_INSERTTABLE_TEXT_AUTOFIT,
    > - 7,69,77,8
    > + 7,69,140,8
    > CONTROL "Automatic column
    > size",AP_RID_DIALOG_INSERTTABLE_RADIO_AUTO,"Button",
    > - BS_AUTORADIOBUTTON,13,83,108,10
    > + BS_AUTORADIOBUTTON,13,83,148,10
    > CONTROL "Fixed column
    >
    size:",AP_RID_DIALOG_INSERTTABLE_RADIO_FIXED,"Button",
    > BS_AUTORADIOBUTTON,13,100,99,10
    > EDITTEXT
    > AP_RID_DIALOG_INSERTTABLE_VAL_SIZE,124,96,30,14,
    > Index: src/wp/ap/win/ap_Win32Res_DlgList.rc2
    >
    ===================================================================
    > RCS file:
    > /cvsroot/abi/src/wp/ap/win/ap_Win32Res_DlgList.rc2,v
    > retrieving revision 1.5
    > diff -u -r1.5 ap_Win32Res_DlgList.rc2
    > --- src/wp/ap/win/ap_Win32Res_DlgList.rc2 20 Oct
    > 2001 23:43:44 -0000 1.5
    > +++ src/wp/ap/win/ap_Win32Res_DlgList.rc2 3 Sep 2003
    > 19:51:56 -0000
    > @@ -65,69 +65,70 @@
    > #include <winresrc.h>
    > LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
    >
    > -AP_RID_DIALOG_LIST DIALOGEX 0, 0, 332, 263
    > +AP_RID_DIALOG_LIST DIALOGEX 0, 0, 367, 263
    > STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION |
    > WS_SYSMENU
    > CAPTION "Lists for - "
    > FONT 8, "MS Sans Serif"
    > BEGIN
    > - EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_START_AT,85,139,39,14,
    > + EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_START_AT,132,139,39,14,
    > ES_AUTOHSCROLL
    > CONTROL
    >
    "Spin1",AP_RID_DIALOG_LIST_SPIN_START_AT,"msctls_updown32",
    > UDS_SETBUDDYINT |
    > UDS_ALIGNRIGHT | UDS_AUTOBUDDY |
    > - UDS_ARROWKEYS,123,139,11,14
    > - EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_LIST_ALIGN,85,176,39,14,
    > + UDS_ARROWKEYS,170,139,11,14
    > + EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_LIST_ALIGN,132,176,39,14,
    > ES_AUTOHSCROLL
    > CONTROL
    > "Spin1",AP_RID_DIALOG_LIST_SPIN_LIST_ALIGN,
    >
    > "msctls_updown32",UDS_ALIGNRIGHT | UDS_AUTOBUDDY |
    > - UDS_ARROWKEYS,123,158,9,14
    > - EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_INDENT_ALIGN,85,193,39,14,
    > + UDS_ARROWKEYS,170,158,9,14
    > + EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_INDENT_ALIGN,132,193,39,14,
    > ES_AUTOHSCROLL
    > CONTROL
    > "Spin1",AP_RID_DIALOG_LIST_SPIN_INDENT_ALIGN,
    >
    > "msctls_updown32",UDS_ALIGNRIGHT | UDS_AUTOBUDDY |
    > - UDS_ARROWKEYS,123,176,11,14
    > - DEFPUSHBUTTON
    > "&Apply",AP_RID_DIALOG_LIST_BTN_APPLY,186,242,50,14
    > - PUSHBUTTON
    > "&Close",AP_RID_DIALOG_LIST_BTN_CLOSE,275,242,50,14
    > - COMBOBOX
    > AP_RID_DIALOG_LIST_COMBO_TYPE,83,7,64,46,
    > + UDS_ARROWKEYS,170,176,11,14
    > + DEFPUSHBUTTON
    > "&Apply",AP_RID_DIALOG_LIST_BTN_APPLY,214,242,50,14
    > + PUSHBUTTON
    > "&Close",AP_RID_DIALOG_LIST_BTN_CLOSE,303,242,50,14
    > + COMBOBOX
    > AP_RID_DIALOG_LIST_COMBO_TYPE,114,7,72,46,
    > CBS_DROPDOWNLIST | WS_VSCROLL |
    > WS_TABSTOP
    > - LTEXT
    > "Type:",AP_RID_DIALOG_LIST_STATIC_TYPE,7,7,68,8
    > - LTEXT
    > "Style:",AP_RID_DIALOG_LIST_STATIC_STYLE,7,30,68,8
    > - COMBOBOX
    > AP_RID_DIALOG_LIST_COMBO_STYLE,83,29,72,110,
    > + LTEXT
    > "Type:",AP_RID_DIALOG_LIST_STATIC_TYPE,7,7,100,8
    > + LTEXT
    > "Style:",AP_RID_DIALOG_LIST_STATIC_STYLE,7,30,94,8
    > + COMBOBOX
    > AP_RID_DIALOG_LIST_COMBO_STYLE,113,29,72,110,
    > CBS_DROPDOWNLIST | WS_VSCROLL |
    > WS_TABSTOP
    > PUSHBUTTON "Set Default
    > Values",AP_RID_DIALOG_LIST_BUTTON_DEFAULT,7,
    > - 54,100,14
    > - GROUPBOX
    >
    "Custom",AP_RID_DIALOG_LIST_GROUP_CUSTOM,7,74,146,145
    > - LTEXT
    >
    "Format:",AP_RID_DIALOG_LIST_STATIC_FORMAT,15,86,58,14
    > - LTEXT
    > "Font:",AP_RID_DIALOG_LIST_STATIC_FONT,15,104,58,14
    > - LTEXT
    >
    "Decimal:",AP_RID_DIALOG_LIST_STATIC_DECIMAL,15,122,58,14
    > - LTEXT
    >
    "Level:",AP_RID_DIALOG_LIST_STATIC_LEVEL,15,158,58,14
    > - LTEXT "Start
    > At:",AP_RID_DIALOG_LIST_STATIC_START_AT,15,140,58,
    > + 54,119,14
    > + GROUPBOX
    >
    "Custom",AP_RID_DIALOG_LIST_GROUP_CUSTOM,7,74,184,142
    > + LTEXT
    >
    "Format:",AP_RID_DIALOG_LIST_STATIC_FORMAT,15,86,108,14
    > + LTEXT
    > "Font:",AP_RID_DIALOG_LIST_STATIC_FONT,15,104,108,14
    > + LTEXT
    >
    "Decimal:",AP_RID_DIALOG_LIST_STATIC_DECIMAL,15,122,108,
    > 14
    > + LTEXT
    >
    "Level:",AP_RID_DIALOG_LIST_STATIC_LEVEL,15,158,108,14
    > + LTEXT "Start
    > At:",AP_RID_DIALOG_LIST_STATIC_START_AT,15,140,
    > + 108,14
    > LTEXT "List
    > Align:",AP_RID_DIALOG_LIST_STATIC_LIST_ALIGN,15,
    > - 176,58,14
    > + 176,108,14
    > LTEXT "Indent
    > Align:",AP_RID_DIALOG_LIST_STATIC_INDENT_ALIGN,
    > - 15,194,58,14
    > - EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_FORMAT,85,85,39,14,
    > + 15,194,108,14
    > + EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_FORMAT,132,85,39,14,
    > ES_AUTOHSCROLL
    > - EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_DECIMAL,85,121,39,14,
    > + EDITTEXT
    > AP_RID_DIALOG_LIST_EDIT_DECIMAL,132,121,39,14,
    > ES_AUTOHSCROLL
    >
    === message truncated ===

    __________________________________
    Do you Yahoo!?
    Yahoo! SiteBuilder - Free, easy-to-use web site design software
    http://sitebuilder.yahoo.com



    This archive was generated by hypermail 2.1.4 : Wed Sep 03 2003 - 16:08:57 EDT