From: msevior_at_physics.unimelb.edu.au
Date: Mon Mar 15 2004 - 02:48:43 EST
>
> Some justification fixes: some fixes of bugs I introduced with the
> block-width cache removal and the extraction of things from
> fp_TextRun into GR_RenderInfo. I have also removed the second call to
> breakParagraph() inside fl_BlockLayout::format() which was put in as
> a hack. Things are not completely right yet: the width of last space
> on line sometimes changes slightly if characters are deleted from the
> previous line; I will continue working on this.
>
> My overall feeling is that the block format() routine and the line
> breaker breakParagraph() routine are not very well thought through,
> particularly who is responsible for what. They have kind of evolved
> as hacks have been added to cover over various problems and the
> result is that the code is not very efficient and verious procedures
> are carried out repeatedly and indiscriminately. I think the whole
> line-breaking algorithm is a serious candidate for a complete
> rewrite, particularly as we spend lot of time inside this code.
>
Hi Tomas,
This really scares me. We're currently going through another
bought of major instablitlies as you do your thing with the new
graphics classes.
I don't mind this because it buys as a lot of extra functionality in the
long run.
Before you attempt more rewrites, please get us back to where we were
before the latest graphics class rewrites occurred.
Secondly please reassure us you'll see any changes you make through until
it all works again. I probabally caused a lot of the ugly code you in
those methods and classes as I tried to make 2.0 usable around this time
last year.
Cheers
Martin
> Tomas
>
>
This archive was generated by hypermail 2.1.4 : Mon Mar 15 2004 - 02:50:52 EST