This is a very nice and clean patch; there are, however, two things I
would like to be changed before this is committed:
ap_Prefs_SchemesIds.h: there should no preference keys defined
conditionally; it is OK to define preference values conditionally, but
the hildon-specific keys should be just added unconditionaly, so that we
have a consistent set of keys across the platforms (if I am not mistaken
AP_PREF_KEY_SimpleBarVisible is defined conditionally).
ap_Strings_Id.h: similar as above; hildon specifi strings should be just
added unconditionally, so that the string set is consistent.
Tomas
Renato Araujo Oliveira Filho wrote:
> Hi guys,
>
> I finally had some time to work on the merging of the maemo changes with
> cvs head. attached there is a version of the patch, if you could take a
> look it would be appreciate.
>
> Take a look in the link, for abiword pictures runing in nokia 770:
> http://www.marceloeduardo.com/blog/
>
>
> Renato Araujo
___________________________________________________________
Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com
Received on Fri Jun 17 08:59:48 2005
This archive was generated by hypermail 2.1.8 : Fri Jun 17 2005 - 08:59:50 CEST