On Fri, 2005-06-17 at 07:59 +0100, Tomas Frydrych wrote:
>
> This is a very nice and clean patch; there are, however, two things I
> would like to be changed before this is committed:
>
> ap_Prefs_SchemesIds.h: there should no preference keys defined
> conditionally; it is OK to define preference values conditionally, but
> the hildon-specific keys should be just added unconditionaly, so that we
> have a consistent set of keys across the platforms (if I am not mistaken
> AP_PREF_KEY_SimpleBarVisible is defined conditionally).
>
> ap_Strings_Id.h: similar as above; hildon specifi strings should be just
> added unconditionally, so that the string set is consistent.
>
I'll address these problems.
Hub
-- Crazy French - http://www.figuiere.net/hub/Received on Fri Jun 17 18:32:45 2005
This archive was generated by hypermail 2.1.8 : Fri Jun 17 2005 - 18:32:48 CEST