yay for late replies.
> Thanks for your comments. I'm trying to make it fit in, but I'm not that
> familiar with the code structure as a whole.
>
> > Could you s/can_break_at/canBreakAt ? The underscores are very C-like in
> > our cool C++ code.
>
> XAP_EncodingManager::can_break_at() is not my function. It was originally
> defined in xap_EncodingManager.cpp using that name. I just changed what it
> did so I didn't change the name. Do you want me to?
Ah right. Well, I can't force you, but it would be a bit more
consistent. Nothing really important though.
> > I see that you made it a static void function. Why
> > not place it conveniently in a GR_Graphics::canBreakAt() function?
>
> It's not defined "static void". It's defined as a normal member
> function returning "bool". It's called from GR_Graphics::canBreak(). Tomas
> asked me to put the functionality in xap_EncodingManager.cpp rather than
> gr_Graphics.cpp. Do you mean westernCanBreakAt? That's defined static
> because it's only ever called from can_break_at(). It's only job is to
> make the code easier to read.
I was blind. Sorry.
Marc
Received on Thu Mar 17 21:02:44 2005
This archive was generated by hypermail 2.1.8 : Thu Mar 17 2005 - 21:02:46 CET