> Hi,
>
> I order to squish warnings, I did get most of them. See the attached
> patch.
>
> I'm not committing the patch right know because I need people to
> *review* it.
OK firstly please use "UT_uint32" not guint.
Next in caes where you do arithmetic on integers always use UT_sint32
never UT_uint32. UT_suint32 should on be used for monotonic counting or
bit fields.
So the patch to squash the warning in
fl_BlockLayout around line 7558 should be redone using UT_sint32.
same for fv_View around line 763
same for ap_TopRuler.h
eeeeekkkk!
if (nesting == 1 && m_styleTable.getItemCount() > (UT_uint32)styleNumber )
I C-style cast!
use static_cast<UT_unit32>(styleNumber)
Apart from them go for it!
Martin
>
>
>
> Hub
>
Received on Wed Mar 23 19:36:08 2005
This archive was generated by hypermail 2.1.8 : Wed Mar 23 2005 - 19:36:11 CET