Re: CVS: commit robsta abi/src/text/fmt/xp fv_View.h fv_VisualDragText.h

>
> On 1/24/07, Tomas Frydrych <tf@o-hand.com> wrote:
>
> [...]
>
>> Ok, it will be really great to have this, and I appreciate you guys
>> working on it, but I think code that deals with dragging text outside
>> of the application and interfacing with the OS dnd mechanism should not
>> go into text/fmt but somewhere into af/xap (or wp/ap), with a suitable
>> xp interface that the layout engine (text/fmt) can be hooked into
>> through.
>
> Agreed, I'm pondering a suitable place. Traditionally such platform
> dependent stuff (e.g. dnd from outside) has been put into the Frame
> classes, but I'd really like to get rid of abiword internals depending
> on all sorts of stuff in the Frame. Maybe the AbiWidget would be the
> correct place, what do you think?
>

The visual drag and drop makes extensive use of the FV_View class. If we
want to move FV_UnixVisualDrag out of text/fmt/unix I think the best place
would be src/wp/ap/unix.

If at all possible we should keep FV_UnixVisualDrag as a child class of
FV_VisualDrag. This will ensure reversibility. The Visual Drag and drop
has been difficult to get right, however doing things with gtk dnd should
be much easier. I can see a potentially tricky problem is making the caret
following the text around.

In addition I think that for abiwidget we should make visually dragged
images be inserted as positioned images at the drop point, rather than
inline iamges at inserted at the caret (which is the current behaviour).

Cheers

Martin

> - Rob
>
Received on Wed Jan 24 14:16:05 2007