Re: [Patch] LaTeX: improve equation edit dialog

On Wed, Apr 9, 2008 at 4:26 PM, Dominic Lachowicz
<domlachowicz@gmail.com> wrote:
>
> Hi Xun,
>
> + if (m_sBackupLatex.size())
> + m_sBackupLatex.clear();
>
> Please just call clear().

+void AP_Dialog_Latex::_backupLatex(void)
+{
+ if (m_sBackupLatex.size())
+ m_sBackupLatex.clear();
+ m_sBackupLatex += m_sLatex;
+}
+

It's not clear to me why you need to use the += operator. I would
just remove the clear() call and use 'm_sBackupLatex = m_sLatex;' in
that function.
Received on Wed Apr 9 23:06:02 2008