Subject: Re: patch: remove snprintf() from xap_Frame.cpp
From: Dom Lachowicz (cinamod@hotmail.com)
Date: Mon Mar 26 2001 - 21:28:36 CST
Only with much pain and displeasure do I apply this patch, though Kevin's
analysis of the situation is quite correct. sprintf bad, snprintf good but
not supported everywhere. We should really code up our own impl of this for
platforms that don't support it...
Dom
>From: Kevin Vajk <kvajk@ricochet.net>
>To: <abiword-dev@abisource.com>
>Subject: patch: remove snprintf() from xap_Frame.cpp
>Date: Mon, 26 Mar 2001 18:33:34 -0800 (PST)
>
>
>I patched abi/src/af/xap/xp/xap_Frame.cpp to not use snprintf().
>
>I really hate removing bounds-checking (although in this case it's
>safe, if I understand what's going on). But, regretfully, snprintf()
>is not portable. Ancient versions of HP-UX don't have a prototype
>for it (although I think it's in libc), and there's a message from
>Sam last November indicating PPC BeOS doesn't have it, either.
>
>Thanks!
>
>--
>- Kevin Vajk
> <kvajk@ricochet.net>
><< snprintf.patch >>
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com
This archive was generated by hypermail 2b25 : Mon Mar 26 2001 - 21:28:47 CST